collect index formatting tests #19661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19661 +/- ##
=======================================
Coverage 91.58% 91.58%
=======================================
Files 150 150
Lines 48867 48867
=======================================
Hits 44755 44755
Misses 4112 4112
Continue to review full report at Codecov.
|
gfyoung
added
Refactor
jreback
requested changes
Feb 15, 2018
| "'2011-01-01 10:00:00+00:00', 'NaT'], " | ||
| "dtype='datetime64[ns, UTC]', freq=None)""") | ||
|
|
||
| with pd.option_context('display.width', 300): |
There was a problem hiding this comment.
looks fine. can you parameterize these (and others that look similar)
There was a problem hiding this comment.
Managed to parametrize a couple of for loops. There is probably more than can be done in the next pass.
This was referenced Feb 16, 2018
jreback
approved these changes
Feb 18, 2018
|
thanks! |
harisbal
pushed a commit
to harisbal/pandas
that referenced
this pull request
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like PeriodIndex/TDI/DTI tests are using different rules for what constitutes test_indexing/test_setops. Double-checking before making a PR:
test_get_loc_* --> test_indexing
test_get_indexer_* --> test_indexing
test_insert_* --> test_indexing
test_where_* --> test_indexing
test_join_* --> test_setops
test_append_* --> test_setops
test_difference_* --> test_setops
Many of these at the moment are in e.g. test_ops or test_period/test_datetime.